feat: adding the rest ofthe nutrition properties from schema.org #4301
Conversation
|
Another thing I forgot to mention is that I don't know what to do for crowdin translations. I updated the en-US for the affected front-end messages with the assumption that en-US is the source for the rest of the translations (I think I saw that configured somewhere). But that will need to be run at some point if this PR is accepted. |
|
|
You just need to update the en-US file. Everything else will be handled by Crowdin automatically 👍 |
tjb1982
force-pushed
the
feat/more-nutrition-from-schema.org
branch
4 times, most recently
from
404f9a2
to
becbb2d
Compare
tjb1982
force-pushed
the
feat/more-nutrition-from-schema.org
branch
2 times, most recently
from
860d1f0
to
58ac1fd
Compare
tjb1982
force-pushed
the
feat/more-nutrition-from-schema.org
branch
from
58ac1fd
to
d525f5f
Compare
What type of PR is this?
What this PR does / why we need it:
Some of the most important schema.org nutrition properties were missing. (See https://schema.org/NutritionInformation)
This adds the remaining ones from schema.org, except for
servingSizewhich would cause problems with the current design wrt translating the unit of measure, which is variable. It's also easy to confuse theservingSize(i.e., "500 g", "4 cups", etc.) concept with the existing and unrelated "servings" (i.e., "serves 4") scaling concept, so I left it out (for now?).In the future it might be nice to allow an EAV type of design to allow users to create arbitrary nutrition entries, but that's more difficult and definitely an edge-case. Out of scope for this regardless.
update: added tests and updated cleaner, migration services, etc.
Which issue(s) this PR fixes:
N/A
Testing
Manually tested with the following URL import: https://www.twopeasandtheirpod.com/vegetarian-taco-skillet/
This recipe included saturated fat and cholesterol.
Updated autoated unit/integration tests to account for these new entries.