Rework virtual files #363
Merged
Rework virtual files #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Volar, the ESM, JSX, and markdown parts of virtual files had to map character by character, with parts shadowed by whitespace characters. This was still how virtual files were built. However, because of how Volar mappings work, this is unnecessary. This change overhauls how virtual files are generated. This leads to more flexibility of virtual files, meaning we can omit or inject content. This is already leveraged in several ways: - Markdown nodes in MDX are represented by TypeScript fragments. This provides compatibility with JSX elements that require children on a type level. - Markdown text nodes in MDX are represented by TypeScript JSX expressions containing an empty string. - JavaScript chunks are represented in the virtual markdown files as HTML comments.
remcohaszing
added
🦋 type/enhancement
|
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Before Volar, the ESM, JSX, and markdown parts of virtual files had to map character by character, with parts shadowed by whitespace characters. This was still how virtual files were built. However, because of how Volar mappings work, this is unnecessary.
This change overhauls how virtual files are generated. This leads to more flexibility of virtual files, meaning we can omit or inject content.
This is already leveraged in several ways: