Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nom_addLocalSectionDV in MPhys wrapper #261

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eytanadler
Copy link
Collaborator

@eytanadler eytanadler commented Feb 13, 2025

Purpose

The parameters to addLocalSectionDV in the MPhys wrapper are passed without keyword arguments, which means they default to the order the keyword arguments were defined. As a result, the variables were getting mixed up when addLocalSectionDV was called and the answer was wrong.

This also fixes adding pointsets to children, which happens already in DVGeometry.addPointSet and doesn't need to be repeated in OM_DVGEO.nom_addPointSet.

Expected time until merged

1 day

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested a review from a team as a code owner February 13, 2025 20:04
@eytanadler eytanadler requested review from hajdik, ArshSaja and A-CGray and removed request for ArshSaja February 13, 2025 20:04
A-CGray
A-CGray previously approved these changes Feb 13, 2025
Copy link
Member

@A-CGray A-CGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.04%. Comparing base (0cabf17) to head (8414c85).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   67.03%   67.04%   +0.01%     
==========================================
  Files          47       47              
  Lines       12331    12326       -5     
==========================================
- Hits         8266     8264       -2     
+ Misses       4065     4062       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants