Fix nom_addLocalSectionDV
in MPhys wrapper
#261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The parameters to
addLocalSectionDV
in the MPhys wrapper are passed without keyword arguments, which means they default to the order the keyword arguments were defined. As a result, the variables were getting mixed up whenaddLocalSectionDV
was called and the answer was wrong.This also fixes adding pointsets to children, which happens already in
DVGeometry.addPointSet
and doesn't need to be repeated inOM_DVGEO.nom_addPointSet
.Expected time until merged
1 day
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable