Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version update #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

version update #76

wants to merge 1 commit into from

Conversation

ArshSaja
Copy link
Contributor

@ArshSaja ArshSaja commented Feb 6, 2025

Purpose

This PR updates the minimum packages requirements and version of ADflow based on this GitHub issue

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ArshSaja ArshSaja requested a review from a team as a code owner February 6, 2025 16:45
@ArshSaja ArshSaja requested review from eirikurj and anilyil February 6, 2025 16:45
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 17.95%. Comparing base (86116bc) to head (0897714).

Files with missing lines Patch % Lines
cgnsutilities/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   17.95%   17.95%           
=======================================
  Files           3        3           
  Lines        2323     2323           
=======================================
  Hits          417      417           
  Misses       1906     1906           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArshSaja ArshSaja requested a review from A-CGray February 6, 2025 17:03
@marcomangano
Copy link
Contributor

I would wait to merge this until #66 (and maybe #75 ?) are merged, they should be done in a few days.

@eirikurj
Copy link
Contributor

Approved, but will wait with merging as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants