Remove simpleOCart and update imports

[sseraj]

Purpose

I removed simpleOCart (which was moved to pyHyp in mdolab/pyhyp#61), cleaned up some of the imports, and updated the dependencies in setup.py.

Expected time until merged

One week (and after mdolab/MACH-Aero#80 is merged)

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (non-backwards-compatible fix or feature)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Documentation update
• Maintenance update
• Other (please describe)

Testing

Checklist

• I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
• I have run unit and regression tests which pass locally with my changes
• I have added new tests that prove my fix is effective or that my feature works
• I have added necessary documentation

[codecov]

Codecov Report

Merging #54 (fe7e321) into main (89b97fe) will increase coverage by 0.54%.
The diff coverage is 9.62%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   21.25%   21.79%   +0.54%     
==========================================
  Files           3        3              
  Lines        2329     2271      -58     
==========================================
  Hits          495      495              
+ Misses       1834     1776      -58     

Impacted Files	Coverage Δ
cgnsutilities/cgns_utils.py	0.00% <0.00%> (ø)
cgnsutilities/cgnsutilities.py	27.67% <9.60%> (+0.71%)	⬆️
cgnsutilities/__init__.py	100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[akleb]

So I see that we are leaving scipy and pyspline as requirements for "advanced features" so the imports are left in. The advanced tag seems a little weird to me (I would just think everything is required always). If we are okay with the advanced tag then this looks good to me.

[akleb]

Why did we move import re outside, but not import scipy

[sseraj]

Keeping the SciPy import inside the function means that the user does not need to have SciPy if they are not using the function. This is directly related to keeping it as an 'advanced' dependency.

I added the 'advanced' features because I didn't want to add pySpline as a hard dependency for a single function (rebunch) that I'm pretty sure no one uses. I think adding SciPy as a hard dependency is justifiable though if we want to do that because it doesn't require compiling another MDO Lab code.

[akleb]

Yeah, I was thinking something along these lines. SciPy is a pretty common package.

[ewu63]

I would be okay with adding scipy as a dependency, but it probably makes sense to keep pyspline out. Also, we may want to bump the version here.

[akleb]

Any reason why we took the install instructions out of the readme?

[sseraj]

Any reason why we took the install instructions out of the readme?

The instructions got moved to the Sphinx docs in #55. That's consistent with where the rest of the MACH-Aero repos have the installation guide.