feat(rari): support rari as beta feature #12051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
merge conflicts 🚧
github-actions
bot
removed
the
merge conflicts 🚧
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
merge conflicts 🚧
argl
reviewed
Nov 25, 2024
| @@ -69,7 +69,14 @@ export async function runMakePopularitiesFile({ | |||
| pageviews.slice(0, maxUris).forEach(([uri, popularity]) => { | |||
| popularities[uri] = parseFloat(popularity.toFixed(5)); | |||
| }); | |||
| fs.writeFileSync(outfile, JSON.stringify(popularities, null, 2)); | |||
| fs.writeFileSync( | |||
There was a problem hiding this comment.
@fiji-flo this implements the updated format
github-actions
bot
removed
the
merge conflicts 🚧
fiji-flo
commented
Nov 27, 2024
| @@ -14,36 +15,39 @@ | |||
| "yari-tool": "tool/cli.js" | |||
| }, | |||
| "scripts": { | |||
| "ai-help-macros": "cross-env NODE_OPTIONS='--no-warnings=ExperimentalWarning --loader ts-node/esm' node scripts/ai-help-macros.ts", | |||
| "ai-help-macros": "cross-env NODE_OPTIONS=\"--no-warnings=ExperimentalWarning --loader ts-node/esm\" node scripts/ai-help-macros.ts", | |||
There was a problem hiding this comment.
These are windows fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds initial support for rari and uses rari to deploy to testing.
Problem
We want to enable writers and contributors to seamlessly migrate.
Solution
Introduce
yarn start:rarito preview the new system.This also:
How did you test this change?
Locally and on testing.