Skip to content

Commit

Permalink
Avoid confusing CI reporting (#4953)
Browse files Browse the repository at this point in the history
If the tests fails before starting the server (for instance while running eslint), the step debugging the server output was producing weird errors due to output files not being found.
  • Loading branch information
stof authored Nov 16, 2021
1 parent e1e87f4 commit 4d099c4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
run: yarn test:client

- name: Build and start server
id: server
env:
ENV_FILE: testing/.env
run: |
Expand Down Expand Up @@ -79,7 +80,7 @@ jobs:
diff -s testing/content/files/en-us/markdown/tool/h2m/index.md testing/content/files/en-us/markdown/tool/h2m/expected.md
- name: Debug server's stdout and stderr if tests failed
if: failure()
if: failure() && steps.server.outcome != 'skipped'
run: |
echo "STDOUT..................................................."
cat /tmp/stdout.log
Expand Down

0 comments on commit 4d099c4

Please sign in to comment.