Fix bug with config check script for native-messaging
#578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup instruction and specific to `python3`, and the `ping_pong_win.bat` has the command `call python3`, however the `check_config_win.py` is checking for the string literal `"call python "` which will always evaluate to false due to the trailing space.
jakedemian
changed the title
jakedemian
changed the title
native-messaging
jakedemian
commented
Feb 12, 2025
| @@ -45,7 +45,7 @@ | |||
| py_lines = open(bat_path, 'r').readlines() | |||
| py_path = None | |||
| for line in py_lines: | |||
| if line.startswith('call python '): | |||
| if line.startswith('call python3 '): | |||
There was a problem hiding this comment.
This did not previously align with the actual text that is in the .bat:
github-actions
bot
added
the
idle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The setup instructions for
native-messagingare specific topython3. Likewise,ping_pong_win.bathas the commandcall python3.webextensions-examples/native-messaging/app/ping_pong_win.bat
Line 3 in 2ecc219
There is a script to ensure you've got everything configured correctly,
check_config_win.py. However, in this check script we're checking for the string literal"call python "within the.batfile, which will always evaluate to false due to the trailing space. Due to this, a person could be in a state where everything is actually configured correctly, but the check script incorrectly responds with an error.This PR changes
"call python " to"call python3"` in order to align the check script with the setup instructions.Motivation
I was trying to get the native messaging example set up on my PC but ran into some confusion when the check script was giving me false negatives