-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Prepare JS French section for Markdown #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54b7cd4
to
cc3f20a
Compare
cc3f20a
to
71776e7
Compare
Amazing! When you run the conversion tool you will get a report talking about all the things that couldn't get converted, and this may flag some extra things that need to get done. There's a bit of explanation of the report's format here: mdn/content#5193 (comment). Of course please feel free to ask if you have questions :). |
Converting this as a draft as long as the output of the converter is not clean. |
@tristantheb En me mettant à ta place, je me dis que celle-ci va être plutôt compliquée à revoir de façon classique. N'hésite pas si tu as besoin d'indications ou d'un coup de main (quitte à faire une revue "statistique" en prenant quelques docs au hasard...) L'idée de cette PR est d'avoir un rapport de |
@wbamberg If you have a few moments, I'd really appreciate a look at the last report (cf. link from previous comment) to check if that seems ok for you or if I missed something. |
Hey @SphinxKnight . I see a couple of things that might be worth a look: code (7)7 unconvertible
The issue here is that you can't represent this directly in GFM. Something like:
....will be rendered like
...rather than:
The converter is clever enough to invert the nesting in cases like:
...to generate markdown like:
....which renders properly:
But this trick only works, of course, if the inner content is the same as the outer content. Probably the converter should just discard this internal markup, but so far it's been simpler to remove it manually in the content. I guess I removed them in mdn/content#6880. img[alt="Stack, heap, queue"]...Probably this isn't being converted because of inline styles? Apart from these there's nothing obviously needing work. It might be worth looking through some of the unconverted tables to see if any of them are easily fixed, but as noted we expect many tables to be unconvertible (and per mdn/content#7342, sometimes we probably want to use HTML even if a table can be converted!). Note that the summary only shows the top 20 unconvertibles, so there might be a few which aren't listed there. Honestly we should tweak the report so it shows them all. Nice work, fr l10n people! |
Thanks @wbamberg, I'll address the code in another PR and then, I'll open the PR for HTML -> MD for JS section in fr :) |
This is a follow-up of https://github.com/mdn/translated-content/discussions/1236
I tried to follow @wbamberg PRs and I assume review would be easier to follow commit per commit.
I did not yet try to convert the section using the conversion tool.