This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
bug 1301102: Switch compressor to yuglify #3962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitlock
force-pushed
the
use_yuglify_1301102
branch
from
94c05dc to
81d2124
Compare
|
Force-push to rebase on master |
|
Same error in TravisCI when compressing jQuery that I get in my Vagrant VM, so it's not a VM-only issue. |
|
Same issue already raies in socorro mozilla-services/socorro#3150 |
|
I think this is too many strikes against yuglify. Closing the PR, returning to bug 1301102 for further discussion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the JS and CSS compressors to yuglify, as specified in bug 1301102. This does not work locally:
vagrant provisiondoes not install yuglify for me. It is unclear if this is because I've done something to my Vagrant box, or because there is something wrong with ansible 1.9.2, or something else. I installed locally in my VM withsudo npm install yuglify --global../manage.py collectstaticIt fails on compressing jQuery.I'm opening a pull request to see if TravisCI has the same issues I have locally, and for further discussion on these changes. Do not merge.