Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html): provide corresponding 'id's for 'for' attributes #2678

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix(html): provide corresponding 'id's for 'for' attributes #2678

merged 1 commit into from
Dec 4, 2023

Conversation

OnkarRuikar
Copy link
Contributor

Many <label for= do not have corresponding element with ids.

Without the ids the for attributes are redundant.

@OnkarRuikar OnkarRuikar requested review from a team as code owners December 4, 2023 04:34
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team December 4, 2023 04:34
estelle
estelle approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!!!

@estelle estelle merged commit 49a3dca into mdn:main Dec 4, 2023
5 checks passed
@mdn-bot mdn-bot mentioned this pull request Dec 4, 2023
Merged
@OnkarRuikar OnkarRuikar deleted the html_for_ids branch December 4, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @estelle