Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): run all linting actions #2576

Merged
merged 10 commits into from
Oct 10, 2023
Merged

feat(ci): run all linting actions #2576

merged 10 commits into from
Oct 10, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR updates the GitHub Action to test a PR to ensure it also checks Prettier formatting.

@queengooborg queengooborg requested a review from bsmth August 2, 2023 17:15
@queengooborg queengooborg requested a review from a team as a code owner August 2, 2023 17:15
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, missed the failing CI, what's the issue here?

@bsmth
Copy link
Member

bsmth commented Aug 7, 2023

oops, missed the failing CI, what's the issue here?

Copying from the logs:

Error:  live-examples/html-examples/inline-text-semantics/rtc.html: SyntaxError: Unexpected closing tag "rtc". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags (10:5)
Error:     8 |     <rtc xml:lang="en" style="ruby-position: over;">
Error:     9 |         <rp>(</rp><rt>Malaysia</rt><rp>)</rp>
Error:  > 10 |     </rtc>
Error:       |     ^^^^^^
Error:    11 | </ruby>
Error:    12 |

@queengooborg
Copy link
Collaborator Author

Looks like bad formatting in a file. We should probably fix that and then merge this immediately after to prevent regressions in the future.

@bsmth
Copy link
Member

bsmth commented Aug 8, 2023

There's an implied closing tag (spec) so Prettier is okay with this:

<ruby xml:lang="zh-Hant" style="ruby-position: under">
  <rbc>
    <rb></rb><rp>(</rp><rt></rt><rp>)</rp> <rb></rb><rp>(</rp><rt>lái</rt><rp>)</rp> <rb>西</rb><rp>(</rp
    ><rt></rt><rp>)</rp> <rb></rb><rp>(</rp><rt></rt><rp>)</rp>
  </rbc>
  <rtc xml:lang="en" style="ruby-position: over"> </rtc><rp>(</rp><rt>Malaysia</rt><rp>)</rp>
</ruby>

But it looks pretty gnarly compared to the original:

<ruby xml:lang="zh-Hant" style="ruby-position: under;">
    <rbc>
        <rb></rb><rp>(</rp><rt></rt><rp>)</rp>
        <rb></rb><rp>(</rp><rt>lái</rt><rp>)</rp>
        <rb>西</rb><rp>(</rp><rt></rt><rp>)</rp>
        <rb></rb><rp>(</rp><rt></rt><rp>)</rp>
    </rbc>
    <rtc xml:lang="en" style="ruby-position: over;">
        <rp>(</rp><rt>Malaysia</rt><rp>)</rp>
    </rtc>
</ruby>

@bsmth
Copy link
Member

bsmth commented Aug 23, 2023

This depends on the linked PR:

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Sep 23, 2023
* chore: Ignore implicit closing bracket in rtc element

* chore: add rtc element example to .prettierignore
@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Sep 27, 2023
@caugner caugner requested review from a team as code owners October 10, 2023 15:06
@caugner caugner requested review from estelle and removed request for a team October 10, 2023 15:06
@caugner caugner changed the title Run all linting actions in CI workflow feat(ci): run all linting actions Oct 10, 2023
@caugner caugner merged commit c7380db into main Oct 10, 2023
6 checks passed
@caugner caugner deleted the queengooborg-patch-1 branch October 10, 2023 15:30
@caugner
Copy link
Contributor

caugner commented Oct 10, 2023

Thank you @queengooborg! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants