-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): run all linting actions #2576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, missed the failing CI, what's the issue here?
Copying from the logs:
|
Looks like bad formatting in a file. We should probably fix that and then merge this immediately after to prevent regressions in the future. |
There's an implied closing tag (spec) so Prettier is okay with this: <ruby xml:lang="zh-Hant" style="ruby-position: under">
<rbc>
<rb>馬</rb><rp>(</rp><rt>mǎ</rt><rp>)</rp> <rb>來</rb><rp>(</rp><rt>lái</rt><rp>)</rp> <rb>西</rb><rp>(</rp
><rt>xī</rt><rp>)</rp> <rb>亞</rb><rp>(</rp><rt>yà</rt><rp>)</rp>
</rbc>
<rtc xml:lang="en" style="ruby-position: over"> </rtc><rp>(</rp><rt>Malaysia</rt><rp>)</rp>
</ruby> But it looks pretty gnarly compared to the original: <ruby xml:lang="zh-Hant" style="ruby-position: under;">
<rbc>
<rb>馬</rb><rp>(</rp><rt>mǎ</rt><rp>)</rp>
<rb>來</rb><rp>(</rp><rt>lái</rt><rp>)</rp>
<rb>西</rb><rp>(</rp><rt>xī</rt><rp>)</rp>
<rb>亞</rb><rp>(</rp><rt>yà</rt><rp>)</rp>
</rbc>
<rtc xml:lang="en" style="ruby-position: over;">
<rp>(</rp><rt>Malaysia</rt><rp>)</rp>
</rtc>
</ruby> |
This depends on the linked PR: |
* chore: Ignore implicit closing bracket in rtc element * chore: add rtc element example to .prettierignore
Thank you @queengooborg! 🎉 |
This PR updates the GitHub Action to test a PR to ensure it also checks Prettier formatting.