Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed folder structure on readme & Code snippet on CSS Layer web page #2518

Closed
wants to merge 2 commits into from

Conversation

RolakeAnifowose
Copy link

Description

The CSS class used on the layer example page wasn't displaying the correct style. I renamed the class.
The folder structure contained in the README.md file is outdated. Updated it to reflect the folders currently contained in the repository.

Edited the README.nd file so the folder structure matches what is currently there.
Edited the at-rule-layer.html and at-rule-layer.css files to fix the styling issue for the code editor.

Motivation

Did this as my first open-source contribution

Additional details

Related issues and pull requests

Fixes #2472
Fixes #2510

@github-actions
Copy link

github-actions bot commented May 3, 2023

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

Copy link
Member

@NiedziolkaMichal NiedziolkaMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the @layer example are no longer needed, because they have been fixed by a different pull request.

I also think that the proposed explanation of folder structure is not good enough. Descriptions of each directory are outdated, [bin] is missing, it should also explain subdirectories of [live-examples]. This pull request also changes package-lock.json, which shouldn't be done.

@github-actions
Copy link

github-actions bot commented May 5, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@NiedziolkaMichal NiedziolkaMichal mentioned this pull request May 9, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jun 5, 2023
@estelle estelle closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months. merge conflicts 🚧
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Folder structure" section on README is outdated The "Try it" box shows wrong output
3 participants