Skip to content

Fix usages of <div class="hidden"> containing code blocks for Markdown conversion #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2021
Merged

Fix usages of <div class="hidden"> containing code blocks for Markdown conversion #7288

merged 3 commits into from
Jul 26, 2021

Conversation

dukecat0
Copy link
Contributor

@dukecat0 dukecat0 commented Jul 26, 2021 •
edited
Loading

What was wrong/why is this fix needed? (quick summary only)

Fix usages of <div class="hidden"> containing code blocks for Markdown conversion

Issue number (if there is an associated issue)

Fixes #7256

Anything else that could help us review it

Related to #5865

@dukecat0 dukecat0 requested a review from a team as a code owner July 26, 2021 13:37
@dukecat0 dukecat0 requested review from mirunacurtean and removed request for a team July 26, 2021 13:37
@dukecat0 dukecat0 changed the title [Markdown] [CSS] Fix usages of <div class="hidden"> containing code blocks Fix usages of <div class="hidden"> containing code blocks for Markdown conversion Jul 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2021 •
edited
Loading

Preview URLs

Flaws

Note! 40 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/:empty
Title: :empty
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/prefix does not exist

URL: /en-US/docs/Web/CSS/CSS_Transitions/Using_CSS_transitions
Title: Using CSS transitions
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/font-weight
Title: font-weight
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/CSS/@media/aspect-ratio
Title: aspect-ratio
on GitHub
Flaw count: 2

  • sectioning:
    • Excess <h3> tag that is NOT at root-level (id='CSS_2', text='CSS')
    • Excess <h3> tag that is NOT at root-level (id='JavaScript', text='JavaScript')

URL: /en-US/docs/Web/CSS/::selection
Title: ::selection
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/stroke-color does not exist
    • /en-US/docs/Web/CSS/fill-color does not exist
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/CSS_Background_and_Borders/Border-radius_generator
Title: Border-radius generator
on GitHub
Flaw count: 1

  • bad_pre_tags:
    • <pre><code>CODE can be just <pre>CODE

URL: /en-US/docs/Web/CSS/CSS_Images/Using_CSS_gradients
Title: Using CSS gradients
on GitHub
Flaw count: 21

  • macros:
    • /en-US/docs/Web/CSS/linear-gradient() redirects to /en-US/docs/Web/CSS/gradient/linear-gradient()
    • /en-US/docs/Web/CSS/radial-gradient() redirects to /en-US/docs/Web/CSS/gradient/radial-gradient()
    • /en-US/docs/Web/CSS/conic-gradient() redirects to /en-US/docs/Web/CSS/gradient/conic-gradient()
    • /en-US/docs/Web/CSS/repeating-linear-gradient() redirects to /en-US/docs/Web/CSS/gradient/repeating-linear-gradient()
    • /en-US/docs/Web/CSS/repeating-radial-gradient() redirects to /en-US/docs/Web/CSS/gradient/repeating-radial-gradient()
    • and 15 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/grid-column-end
Title: grid-column-end
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/url()
Title: url()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/image() redirects to /en-US/docs/Web/CSS/image/image()
    • /en-US/docs/Web/CSS/image-set() redirects to /en-US/docs/Web/CSS/image/image-set()

URL: /en-US/docs/Web/CSS/color_value
Title: <color>
on GitHub
Flaw count: 4

  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/lab()
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/lch()
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/color()
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/CSS/@color-profile

URL: /en-US/docs/Web/CSS/CSS_Animations/Tips
Title: CSS Animations tips and tricks
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/CSS/Using_CSS_transitions

URL: /en-US/docs/Web/CSS/gradient/linear-gradient()
Title: linear-gradient()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/image() redirects to /en-US/docs/Web/CSS/image/image()
    • /en-US/docs/Web/CSS/image-set() redirects to /en-US/docs/Web/CSS/image/image-set()

URL: /en-US/docs/Web/CSS/gradient/repeating-linear-gradient()
Title: repeating-linear-gradient()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/image() redirects to /en-US/docs/Web/CSS/image/image()
    • /en-US/docs/Web/CSS/image-set() redirects to /en-US/docs/Web/CSS/image/image-set()

URL: /en-US/docs/Web/CSS/gradient/repeating-conic-gradient()
Title: repeating-conic-gradient()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/image() redirects to /en-US/docs/Web/CSS/image/image()
    • /en-US/docs/Web/CSS/image-set() redirects to /en-US/docs/Web/CSS/image/image-set()

URL: /en-US/docs/Web/CSS/gradient/conic-gradient()
Title: conic-gradient()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/image() redirects to /en-US/docs/Web/CSS/image/image()
    • /en-US/docs/Web/CSS/image-set() redirects to /en-US/docs/Web/CSS/image/image-set()

URL: /en-US/docs/Web/CSS/gradient/repeating-radial-gradient()
Title: repeating-radial-gradient()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/image() redirects to /en-US/docs/Web/CSS/image/image()
    • /en-US/docs/Web/CSS/image-set() redirects to /en-US/docs/Web/CSS/image/image-set()

URL: /en-US/docs/Web/CSS/gradient/radial-gradient()
Title: radial-gradient()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/image() redirects to /en-US/docs/Web/CSS/image/image()
    • /en-US/docs/Web/CSS/image-set() redirects to /en-US/docs/Web/CSS/image/image-set()

URL: /en-US/docs/Web/CSS/grid-row-end
Title: grid-row-end
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout
Title: CSS Grid Layout
on GitHub
Flaw count: 9

  • macros:
    • /en-US/docs/Web/CSS/repeat redirects to /en-US/docs/Web/CSS/repeat()
    • /en-US/docs/Web/CSS/minmax redirects to /en-US/docs/Web/CSS/minmax()
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout/CSS_Grid,_Logical_Values_and_Writing_Modes
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout/Realising_common_layouts_using_CSS_Grid_
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • and 2 more flaws omitted

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/CSS_Grid_Layout_and_Accessibility
Title: CSS Grid Layout and Accessibility
on GitHub
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Basic_Concepts_of_Grid_Layout
Title: Basic Concepts of grid layout
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/CSS/grid-column-gap redirects to /en-US/docs/Web/CSS/column-gap
    • /en-US/docs/Web/CSS/grid-row-gap redirects to /en-US/docs/Web/CSS/row-gap
    • /en-US/docs/Web/CSS/grid-gap redirects to /en-US/docs/Web/CSS/gap

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Line-based_Placement_with_CSS_Grid
Title: Line-based placement with CSS Grid
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/shorthand_properties does not exist

URL: /en-US/docs/Web/CSS/grid-row-start
Title: grid-row-start
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/font-style
Title: font-style
on GitHub
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/CSS/CSS_Colors/Color_picker_tool
Title: Color picker tool
on GitHub
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Learn/CSS/Styling_boxes/Borders
    • Can't resolve /en-US/docs/Learn/CSS/Styling_boxes/Backgrounds
    • Anchor not lowercase

URL: /en-US/docs/Web/CSS/Specificity
Title: Specificity
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/CSS/Tools/Linear-gradient_Generator
Title: Linear-gradient Generator
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/linear-gradient redirects to /en-US/docs/Web/CSS/gradient/linear-gradient()

URL: /en-US/docs/Web/CSS/grid-column-start
Title: grid-column-start
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/clip-path
Title: clip-path
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/CSS/url redirects to /en-US/docs/Web/CSS/url()
  • broken_links:
    • Can't resolve /en-US/docs/CSS/Understanding_z-index/The_stacking_context
    • Can't resolve /en-US/docs/Applying_SVG_effects_to_HTML_content

External URLs

URL: /en-US/docs/Web/CSS/:empty
Title: :empty
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Containing_block
Title: Layout and the containing block
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Transitions/Using_CSS_transitions
Title: Using CSS transitions
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/border-image-repeat
Title: border-image-repeat
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/font-weight
Title: font-weight
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/image-orientation
Title: image-orientation
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/@media/aspect-ratio
Title: aspect-ratio
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/@media/prefers-reduced-motion
Title: prefers-reduced-motion
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/::selection
Title: ::selection
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Background_and_Borders/Border-image_generator
Title: Border-image generator
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Background_and_Borders/Box-shadow_generator
Title: Box-shadow generator
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Background_and_Borders/Border-radius_generator
Title: Border-radius generator
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Images/Using_CSS_gradients
Title: Using CSS gradients
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/animation-timing-function
Title: animation-timing-function
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/::file-selector-button
Title: ::file-selector-button
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/grid-column-end
Title: grid-column-end
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/url()
Title: url()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/color_value
Title: <color>
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/color_value/color-mix()
Title: color-mix()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Animations/Tips
Title: CSS Animations tips and tricks
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/writing-mode
Title: writing-mode
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/align-content
Title: align-content
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/text-align-last
Title: text-align-last
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/contain
Title: contain
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/transition-timing-function
Title: transition-timing-function
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient
Title: <gradient>
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/linear-gradient()
Title: linear-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/repeating-linear-gradient()
Title: repeating-linear-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/repeating-conic-gradient()
Title: repeating-conic-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/conic-gradient()
Title: conic-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/repeating-radial-gradient()
Title: repeating-radial-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/radial-gradient()
Title: radial-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/grid-row-end
Title: grid-row-end
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/mix-blend-mode
Title: mix-blend-mode
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/-webkit-text-stroke-color
Title: -webkit-text-stroke-color
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/font
Title: font
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/rotate
Title: rotate
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/white-space
Title: white-space
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/image-rendering
Title: image-rendering
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/flex
Title: flex
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout
Title: CSS Grid Layout
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/CSS_Grid_Layout_and_Accessibility
Title: CSS Grid Layout and Accessibility
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Auto-placement_in_CSS_Grid_Layout
Title: Auto-placement in CSS Grid Layout
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/CSS_Grid_Logical_Values_and_Writing_Modes
Title: CSS grids, logical values, and writing modes
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Layout_using_Named_Grid_Lines
Title: Layout using named grid lines
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Box_Alignment_in_CSS_Grid_Layout
Title: Box alignment in CSS Grid Layout
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Relationship_of_Grid_Layout
Title: Relationship of grid layout to other layout methods
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Basic_Concepts_of_Grid_Layout
Title: Basic Concepts of grid layout
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Realizing_common_layouts_using_CSS_Grid_Layout
Title: Realizing common layouts using CSS Grid Layout
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/CSS_Grid_and_Progressive_Enhancement
Title: CSS Grid Layout and Progressive Enhancement
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Grid_Template_Areas
Title: Grid template areas
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Grid_Layout/Line-based_Placement_with_CSS_Grid
Title: Line-based placement with CSS Grid
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/attr()
Title: attr()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/align-items
Title: align-items
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/grid-row-start
Title: grid-row-start
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/font-style
Title: font-style
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/place-items
Title: place-items
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/text-justify
Title: text-justify
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Colors/Color_picker_tool
Title: Color picker tool
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Specificity
Title: Specificity
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Tools/Linear-gradient_Generator
Title: Linear-gradient Generator
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/image/image()
Title: image()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/grid-column-start
Title: grid-column-start
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/justify-content
Title: justify-content
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/@counter-style/system
Title: system
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Using_CSS_custom_properties
Title: Using CSS custom properties (variables)
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/place-content
Title: place-content
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/clip-path
Title: clip-path
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/font-family
Title: font-family
on GitHub

No new external URLs

(this comment was updated 2021-07-26 21:20:10.126861)

@dukecat0 dukecat0 mentioned this pull request Jul 26, 2021
Closed
wbamberg
wbamberg approved these changes Jul 26, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this looks great! Thanks!

@wbamberg wbamberg merged commit 2c11e2b into mdn:main Jul 26, 2021
@dukecat0 dukecat0 deleted the css branch July 27, 2021 03:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@mirunacurtean mirunacurtean Awaiting requested review from mirunacurtean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Markdown] [CSS] Fix usages of <div class="hidden"> containing code blocks
2 participants
@dukecat0 @wbamberg