Skip to content

Fix consecutive dd elements in CSS #6352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2021

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Jun 26, 2021

This is part of #5865, and removes all consecutive <dd> elements in the CSS docs.

Although of course we're allowed to have consecutive <dd> elements in HTML, given the way we use <dl> in MDN, in practice we (almost?) never need them. So to keep things simpler, the Markdown extension we're using for <dl> will not support consecutive <dd> or <dt> elements.

There are some places where we do have consecutive <dd> elements, but I don't think any of the ones I've seen so far (in all the JS and CSS docs) are semantically valid. I'm guessing that a lot of the places we have them are because with the WYSIWYG editor in the old Wiki it was easy to add new <dd> elements by mistake, rather than including multiple paragraphs in a single <dd>.

In #4625 I removed them in the JS docs, and this does the same for the CSS docs.

@github-actions

This comment has been minimized.

@wbamberg wbamberg marked this pull request as ready for review June 26, 2021 16:43
@wbamberg wbamberg requested a review from a team as a code owner June 26, 2021 16:43
@wbamberg wbamberg requested review from mirunacurtean and removed request for a team June 26, 2021 16:43
@sideshowbarker sideshowbarker merged commit 2920d21 into mdn:main Jun 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
@wbamberg wbamberg deleted the css-remove-consecutive-dd branch April 5, 2023 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants