Add md to pr-test diff #5416
Merged
Add md to pr-test diff #5416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregoor
requested review from
a team,
fiji-flo and
peterbe
and removed request for
a team
peterbe
reviewed
May 28, 2021
There was a problem hiding this comment.
I always get nervous about that.
get-diff-action uses minimatch and in their example they have a + before the list of file extensions.
As mentioned in Slack, I think you should include a silly change to file/en-us/mdn/kitchensink/index.html and make sure that file gets built.
|
Looks like I am pinging people to review left-and-right automatically, because the system thinks I am a stranger. Sorry @Rumyra! |
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs |
peterbe
reviewed
Jun 1, 2021
| @@ -58,7 +58,7 @@ jobs: | |||
| - uses: technote-space/[email protected] | |||
| id: git_diff_content | |||
| with: | |||
| PATTERNS: files/**/*.html | |||
| PATTERNS: files/**/*.+(html|md) | |||
There was a problem hiding this comment.
Yay! There are so many ways and I can never remember which is which. Apparently, this here works.
peterbe
reviewed
Jun 1, 2021
peterbe
approved these changes
Jun 1, 2021
Co-authored-by: Peter Bengtsson <[email protected]>
|
Done! Thanks for the hint @peterbe. Shall we merge? |
peterbe
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @peterbe,
I have to admit that I did not try to run this locally (most of all, because I did not know how). My intention here is to make preview work for getting #5193 into shape. Lmkwyt!