-
Notifications
You must be signed in to change notification settings - Fork 22.7k
Remove summary and seoSummary classes from JS docs #4085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I think it is okay to remove the MathML as well. It is probably enough to explain the things in English and it avoids the compat problems with displaying MathML well enough across browsers.
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4083.
This removes all uses of
summary
orseoSummary
in cases where those classes actually do something. In most cases the classes are selecting the first portion of the first paragraph, and in most of those cases I've just removed them so we will use the whole first paragraph. I think this is OK, none of them are very long, and in the other 800-odd pages where we are not using these classes there are many similarly long paragraphs: https://gist.github.com/wbamberg/3e6f1d6d995189596647a7342c3f0d9e.In a few places I've made more extensive changes, for wording, or to try to make the summary more coherent.