Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MIME type for WebDriverBiDi captureScreenshot command #37961

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

juliandescottes
Copy link
Contributor

"image/jpg" is not a valid image MIME type, we should advise to use "image/jpeg" instead.

image/jpg is not a valid image MIME type
@juliandescottes juliandescottes requested a review from a team as a code owner February 4, 2025 16:54
@juliandescottes juliandescottes requested review from pepelsbey and lutien and removed request for a team February 4, 2025 16:54
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/135
Title: Firefox 135 for developers

(comment last updated: 2025-02-26 11:44:52)

Copy link
Contributor

@lutien lutien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bsmth
Copy link
Member

bsmth commented Feb 5, 2025

Noting there's two other occurrences:

./files/en-us/web/css/url_function/index.md:url("data:image/jpg;base64,iRxVB0…");
./files/en-us/learn_web_development/extensions/server-side/node_server_without_framework/index.md:  jpg: "image/jpg",

@bsmth
Copy link
Member

bsmth commented Feb 26, 2025

Let's merge this and I'll get the other two. Thanks, both!

@bsmth bsmth merged commit 6908f0d into main Feb 26, 2025
12 checks passed
@bsmth bsmth deleted the juliandescottes-135-bidi-screenshot-mime-type branch February 26, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants