Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed outdated note (SVG) #37872

Closed
wants to merge 1 commit into from
Closed

removed outdated note (SVG) #37872

wants to merge 1 commit into from

Conversation

estelle
Copy link
Member

@estelle estelle commented Jan 29, 2025

according to the bcd table, backgroundImage has been supported since 2018

@estelle estelle requested a review from a team as a code owner January 29, 2025 23:10
@estelle estelle requested review from hamishwillee and removed request for a team January 29, 2025 23:10
@github-actions github-actions bot added Content:SVG SVG docs size/xs [PR only] 0-5 LoC changed labels Jan 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

@wbamberg
Copy link
Collaborator

It reads like the note is a justification for the example being a particular way, and it links to a page that says similar things. If we remove the note, should we not also rework the example to undo the workaround?

@hamishwillee
Copy link
Collaborator

It reads like the note is a justification for the example being a particular way, and it links to a page that says similar things. If we remove the note, should we not also rework the example to undo the workaround?

Yes, also

according to the bcd table, backgroundImage has been supported since 2018

Where's that? I'm not seeing a mention of it in https://developer.mozilla.org/en-US/docs/Web/SVG/Element/feComposite#browser_compatibility or https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/in (note, I don't fully get what this note means either)

@estelle estelle closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:SVG SVG docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @wbamberg @hamishwillee