Fix wrong shader type in WebGL texture tutorial #37625
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected section "Updating the shaders" > "The vertex shader". The vertex shader passes the texture coordinates to the fragment shader, not to itself.
abstractskies
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
sideshowbarker
approved these changes
Jan 13, 2025
|
Jessy, nice catch 〜 congrats on landing your first docs change here — welcome aboard 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tutorial states that the vertex shader passes texture coordinates to itself, which is incorrect, and does not reflect what the example code actually does.
It should say that the vertex shader passes texture coordinates to the fragment shader (through
vTextureCoord), which in turn uses them to sample the right part of the texture.Motivation
The error might confuse someone not familiar with the graphics pipeline, which is the intended audience of this tutorial.
Additional details
n/a
Related issues and pull requests
n/a