-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pages: CSS box alignment data types #37567
Conversation
Preview URLs
Flaws (245)URL:
URL:
URL:
URL:
URL:
(comment last updated: 2025-01-15 18:35:47) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle few bits for you, but nothing major. Lovely work!
- Properties that use this data type: {{cssxref("align-content")}}, {{cssxref("justify-content")}}, {{cssxref("place-content")}} | ||
- Other box alignment data types: {{cssxref("baseline-position")}}, {{cssxref("content-position")}}, {{cssxref("overflow-position")}}, and {{cssxref("self-position")}} | ||
- [CSS box alignment](/en-US/docs/Web/CSS/CSS_box_alignment) module | ||
- [CSS flexible layout](/en-US/docs/Web/CSS/CSS_flexible_layout) module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is red. Do you mean CSS flexible box layout (https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_flexible_box_layout)?
Same for the other pages that include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL is now right, but the link text is still wrong. Should be "CSS flexible box layout".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, good catch. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle Perfect, except for one remaining issue, which I've commented on in my previous review comment.
I'll approve it so you can merge when ready.
part of openwebdocs/project#215
the data types defined in css box alignment module
fixes openwebdocs/project#215