Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pages: CSS box alignment data types #37567

Merged
merged 7 commits into from
Jan 15, 2025
Merged

New pages: CSS box alignment data types #37567

merged 7 commits into from
Jan 15, 2025

Conversation

estelle
Copy link
Member

@estelle estelle commented Jan 9, 2025

part of openwebdocs/project#215
the data types defined in css box alignment module

fixes openwebdocs/project#215

@estelle estelle requested a review from a team as a code owner January 9, 2025 04:16
@estelle estelle requested review from chrisdavidmills and removed request for a team January 9, 2025 04:16
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 9, 2025
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Preview URLs

Flaws (245)

URL: /en-US/docs/Web/CSS/content-distribution
Title: <content-distribution>
Flaw count: 49

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: css.types.content-distribution

URL: /en-US/docs/Web/CSS/overflow-position
Title: <overflow-position>
Flaw count: 49

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: css.types.overflow-position

URL: /en-US/docs/Web/CSS/self-position
Title: <self-position>
Flaw count: 49

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: css.types.self-position

URL: /en-US/docs/Web/CSS/baseline-position
Title: <baseline-position>
Flaw count: 49

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: css.types.baseline-position

URL: /en-US/docs/Web/CSS/content-position
Title: <content-position>
Flaw count: 49

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: css.types.content-position

(comment last updated: 2025-01-15 18:35:47)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle few bits for you, but nothing major. Lovely work!

files/en-us/web/css/baseline-position/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/baseline-position/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/baseline-position/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/content-distribution/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/content-distribution/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/content-distribution/index.md Outdated Show resolved Hide resolved
- Properties that use this data type: {{cssxref("align-content")}}, {{cssxref("justify-content")}}, {{cssxref("place-content")}}
- Other box alignment data types: {{cssxref("baseline-position")}}, {{cssxref("content-position")}}, {{cssxref("overflow-position")}}, and {{cssxref("self-position")}}
- [CSS box alignment](/en-US/docs/Web/CSS/CSS_box_alignment) module
- [CSS flexible layout](/en-US/docs/Web/CSS/CSS_flexible_layout) module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is red. Do you mean CSS flexible box layout (https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_flexible_box_layout)?

Same for the other pages that include it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is now right, but the link text is still wrong. Should be "CSS flexible box layout".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good catch. thanks.

files/en-us/web/css/overflow-position/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/self-position/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/self-position/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle Perfect, except for one remaining issue, which I've commented on in my previous review comment.

I'll approve it so you can merge when ready.

@estelle estelle merged commit 2592497 into main Jan 15, 2025
10 checks passed
@estelle estelle deleted the aligndatatypes branch January 15, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module landing page: CSS Box Alignment
2 participants