Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New grid examples work #37525

Merged
merged 4 commits into from
Feb 3, 2025
Merged

New grid examples work #37525

merged 4 commits into from
Feb 3, 2025

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Jan 6, 2025

Description

  • moved the grid examples into the page
  • updated the wording on the page
  • updated the grid inspector image
  • Replaced PR #37259

Motivation

  • Helping @bsmth with the migration of examples into content

@dletorey dletorey requested a review from a team as a code owner January 6, 2025 15:39
@dletorey dletorey requested review from chrisdavidmills and bsmth and removed request for a team and chrisdavidmills January 6, 2025 15:39
@github-actions github-actions bot added the size/l [PR only] 501-1000 LoC changed label Jan 6, 2025
@dletorey dletorey mentioned this pull request Jan 6, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited
Loading

Preview URLs

(comment last updated: 2025-01-28 15:38:00)

@bsmth
Copy link
Member

bsmth commented Jan 28, 2025

@dletorey could you update the branch from main?

@github-actions github-actions bot added the Content:Learn Learning area docs label Jan 28, 2025
bsmth
bsmth approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@bsmth bsmth merged commit 4139ce4 into mdn:main Feb 3, 2025
8 checks passed
@dletorey dletorey deleted the new-grid-examples-work branch February 4, 2025 11:31
@Josh-Cena Josh-Cena mentioned this pull request Feb 15, 2025
Closed
@bsmth bsmth mentioned this pull request Mar 18, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:Learn Learning area docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dletorey @bsmth