Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <iframe><fencedframe> in the Accessibility section #37454

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

Nicolapps
Copy link
Contributor

Description

This PR fixes the documentation of <fencedframe> by removing incorrect references to the <iframe> element which should be references to <fencedframe> instead.

Motivation

The documentation of <fencedframe> contains leftovers copied from the documentation of <iframe> in its Accessibility section, which makes it confusing to read.

Additional details

The documentation of `<fencedframe>` contains leftovers copied from the documentation of `<iframe>` in its *Accessibility* section, which makes it confusing to read.
@Nicolapps Nicolapps requested a review from a team as a code owner December 31, 2024 07:39
@Nicolapps Nicolapps requested review from estelle and removed request for a team December 31, 2024 07:39
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed labels Dec 31, 2024
Copy link
Contributor

Preview URLs

Flaws (23)

URL: /en-US/docs/Web/HTML/Element/fencedframe
Title: <fencedframe>: The Fenced Frame element
Flaw count: 23

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/HTML
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/HTML_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/HTML/Introduction_to_HTML
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/HTML/Introduction_to_HTML/Getting_started
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/HTML/Introduction_to_HTML/The_head_metadata_in_HTML
    • and 18 more flaws omitted

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Congratulations on your first merged MDN content PR.
Welcome to the team!

@estelle estelle merged commit 523f8dc into mdn:main Jan 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants