Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Pages: SVGFECompositeElement #37320

Merged
merged 8 commits into from
Jan 31, 2025
Merged

New Pages: SVGFECompositeElement #37320

merged 8 commits into from
Jan 31, 2025

Conversation

yashrajbharti
Copy link
Contributor

part of Missing baseline pages project

@yashrajbharti yashrajbharti requested a review from a team as a code owner December 21, 2024 00:39
@yashrajbharti yashrajbharti requested review from wbamberg and removed request for a team December 21, 2024 00:39
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2024 •
edited
Loading

Preview URLs (8 pages)
Flaws (2)

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/SVGFECompositeElement
Title: SVGFECompositeElement
Flaw count: 2

  • macros:
    • Can't resolve /en-US/docs/Web/API/SVGFECompositeElement/type
    • Can't resolve /en-US/docs/Web/API/SVGFECompositeElement/values

(comment last updated: 2025-01-30 08:10:39)

@estelle estelle self-assigned this Jan 29, 2025
estelle
estelle reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the examples in this PR need work. I made some suggestions relevant to all the pages in this PR.

files/en-us/web/api/svgfecompositeelement/in1/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svgfecompositeelement/in1/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svgfecompositeelement/k3/index.md Outdated Show resolved Hide resolved
yashrajbharti and others added 3 commits January 30, 2025 13:22
@yashrajbharti @github-actions
Update files/en-us/web/api/svgfecompositeelement/in1/index.md
0582a95 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yashrajbharti
add: examples:
41f7bae
@yashrajbharti
Merge branch 'feat/SVGFECompositeElement' of https://github.com/yashr…
2f1c931 
…ajbharti/content into feat/SVGFECompositeElement
@yashrajbharti yashrajbharti requested a review from estelle January 30, 2025 08:10
estelle
estelle approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit e63d38e into mdn:main Jan 31, 2025
8 checks passed
@yashrajbharti yashrajbharti deleted the feat/SVGFECompositeElement branch January 31, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@estelle estelle estelle approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees

@estelle estelle

Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashrajbharti @estelle