Add information about passing null to unset a bind group #36648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
requested review from
wbamberg
and removed request for
a team
github-actions
bot
added
Content:WebAPI
|
Preview URLs
(comment last updated: 2024-11-04 13:17:22) |
3 tasks
|
|
||
| ```js | ||
| // Set bind group in slot 0 | ||
| passEncoder.setBindGroup(0, bindGroup); |
There was a problem hiding this comment.
Nit: bindGroup comes ouf of no where. Maybe call it myBindGroup or reuse uniformBindGroup from above?
There was a problem hiding this comment.
Good call. I've fixed this up, on both this page and the GPURenderBundleEncoder.setBindGroup() page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Chrome 117 onwards, you can pass
nullas the second argument when calling https://developer.mozilla.org/en-US/docs/Web/API/GPUComputePassEncoder/setBindGroup#bindgroup, https://developer.mozilla.org/en-US/docs/Web/API/GPURenderPassEncoder/setBindGroup#bindgroup, and https://developer.mozilla.org/en-US/docs/Web/API/GPURenderBundleEncoder/setBindGroup#bindgroup to unset a previously-set bind group in the specified slot.This PR adds some text to the
bindGroupargument description to specify this and also adds a small example snippet to each page to show what the unsettling code might look like.See https://developer.chrome.com/blog/new-in-webgpu-117#unset_bind_group for evidence of this change.
Note that the above link does not mention GPUComputePassEncoder/setBindGroup, but I tested it and it works there as well.
Motivation
Additional details
Related issues and pull requests
Project issue: #36375