Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(css): Move CSS examples - Learn CSS, Building Blocks p2 #36647

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 4, 2024

Description

As part of an initiative to reduce repo maintenance & code duplication, this PR moves some external examples into content. This PR converts the following macros to live samples:

{{EmbedGHLiveSample("css-examples/learn/images/filter.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/images/filter-text.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/images/shapes.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/layers/basic-cascade.html", '100%', 500)}}
{{EmbedGHLiveSample("css-examples/learn/layers/layer-order.html", '100%', 500)}}
{{EmbedGHLiveSample("css-examples/learn/layers/media-order.html", '100%', 500)}}
{{EmbedGHLiveSample("css-examples/learn/layers/layer-precedence.html", '100%', 500)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/type.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/universal.html", '100%', 750)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/class.html", '100%', 750)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/class-type.html", '100%', 750)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/class-many.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/id.html", '100%', 750)}}
{{EmbedGHLiveSample("css-examples/learn/sizing/intrinsic-image.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/sizing/intrinsic-text.html", '100%', 500)}}
{{EmbedGHLiveSample("css-examples/learn/sizing/height.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/sizing/percent-width.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/sizing/percent-mp.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/sizing/min-height.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/sizing/max-width.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/sizing/vw-vh.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/block.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/inline.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/box-models.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/margin.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/margin-collapse.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/border.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/padding.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/inline-box-model.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/inline-block.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/box-model/inline-block-nav.html", '100%', 700)}}

Motivation

Motivation is described in the project issue.

Related issues and pull requests

@bsmth bsmth requested a review from a team as a code owner November 4, 2024 12:01
@bsmth bsmth requested review from chrisdavidmills and removed request for a team November 4, 2024 12:01
@github-actions github-actions bot added Content:Learn:CSS Learning area CSS docs size/l [PR only] 501-1000 LoC changed labels Nov 4, 2024
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsmth More great work! I just had one comment, but approving so as not to hold this one up, if it was intentional.

@bsmth bsmth requested a review from chrisdavidmills November 7, 2024 10:34
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisdavidmills chrisdavidmills merged commit 033285c into mdn:main Nov 7, 2024
8 checks passed
@bsmth bsmth deleted the css-examples-building-blocks branch November 7, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:CSS Learning area CSS docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants