Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serializable objects list #36389

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

same as title

also add a note indicating how to find serializable objects via webidl

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Oct 17, 2024
Copy link
Contributor

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm
Title: The structured clone algorithm
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/CropTarget does not exist
External URLs (1)

URL: /en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm
Title: The structured clone algorithm

@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 17, 2024 09:25
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner October 17, 2024 09:25
@skyclouds2001 skyclouds2001 requested review from Elchi3 and removed request for a team October 17, 2024 09:25
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @skyclouds2001 !

@wbamberg wbamberg merged commit 37205e6 into mdn:main Oct 21, 2024
7 checks passed
@skyclouds2001 skyclouds2001 deleted the serializable-objects-list branch October 21, 2024 18:09
@hamishwillee
Copy link
Collaborator

@wbamberg Same issue as the transferrable objects - lists should be complete or clearly partial. Upshot we need automation.

I think we should mark up each of these as items as serializable as per IDL, but we could start by using a macro the generate the list. Does that make sense to you?

This list is in the structured clone algorithm. I kind of think we should have lists in https://developer.mozilla.org/en-US/docs/Glossary/Serializable_object , then in structed clone algorithm doc note that you can clone items that are serializable and transfer items that are transferrable.

Alternatively we could have the transferrable list in structured clone page too. But as it is now is inconsistent.

Does this seem reasonable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants