Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): remove content:contents #36386

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

OnkarRuikar
Copy link
Contributor

The contents value hasn't been implemented in any user agent. Also it may change in future:

Issue 3: Should the contents keyword be replaced with content()?

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner October 17, 2024 03:08
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team October 17, 2024 03:08
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Preview URLs

(comment last updated: 2024-10-18 02:57:07)

@wbamberg
Copy link
Collaborator

wbamberg commented Oct 17, 2024

Thanks @OnkarRuikar !

Note that https://pr36386.content.dev.mdn.mozit.cloud/en-US/docs/Web/CSS/content#normal still refers to contents, so this isn't coherent any more.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Oct 17, 2024

Note that pr36386.content.dev.mdn.mozit.cloud/en-US/docs/Web/CSS/content#normal still refers to contents

@wbamberg Good catch! I've reworded the line.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OnkarRuikar This looks good to me. I've left a couple of minor comments but approved it so you can merge when ready.

files/en-us/web/css/content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/content/index.md Outdated Show resolved Hide resolved
@Josh-Cena Josh-Cena merged commit b580c9f into mdn:main Oct 18, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_content_contents branch October 18, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

content: contents is unimplemented
4 participants