-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(manifest): Improvements to scope
page
#36137
Conversation
Preview URLs (comment last updated: 2024-10-29 22:19:01) |
Thanks for the review, Hamish. |
Hi Hamish, thanks a lot for the review! I've done a couple of things in this iteration:
I'm hoping these updates will address your comments. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look really good. I've added some very minor suggestions.
Thanks, I've incorporated your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much! Looking good.
Description
This PR is part of improving the web/manifest docs:
Motivation
To ensure all sections have sufficient explanation, all caveats from spec are covered, and the manifest pages follow a similar template
Additional details
Spec links:
Related issues and pull requests
Tracking issue: mdn/mdn#560
Also:
Fixes #32948