Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MathML ARIA roles information #36133

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Add MathML ARIA roles information #36133

merged 4 commits into from
Oct 25, 2024

Conversation

pepelsbey
Copy link
Member

Description

Adds ARIA roles info to MathML elements:

  • Only the <math> element has one
  • The rest get the “no implicit role” section

Motivation

To start documenting MathML accessibility on MDN.

Additional details

I used the following sources of information:

@pepelsbey pepelsbey requested a review from a team as a code owner September 30, 2024 17:07
@pepelsbey pepelsbey changed the title Add MathML roles information Add MathML ARIA roles information Sep 30, 2024
@github-actions github-actions bot added Content:MathML MathML docs size/m [PR only] 51-500 LoC changed labels Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited
Loading

Preview URLs (32 pages)

(comment last updated: 2024-10-25 11:28:16)

@fred-wang
Copy link
Contributor

This LGTM, although I don't know whether we should mention ATK and AX API roles.

cc @asurkov @spectranaut

@pepelsbey pepelsbey requested review from mdn-bot and a team as code owners October 1, 2024 11:00
@pepelsbey pepelsbey requested review from bsmth, wbamberg and estelle and removed request for a team October 1, 2024 11:00
@github-actions github-actions bot added merge conflicts 🚧 [PR only] Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Other Any docs not covered by another "Content:" label Content:Security Security docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Meta Content in the meta docs Content:Manifest system [PR only] Infrastructure and configuration for the project labels Oct 1, 2024
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed Content:JS JavaScript docs Content:Other Any docs not covered by another "Content:" label Content:Security Security docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Meta Content in the meta docs Content:Manifest system [PR only] Infrastructure and configuration for the project size/xl [PR only] >1000 LoC changed labels Oct 1, 2024
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Oct 1, 2024
@pepelsbey pepelsbey removed request for mdn-bot, a team, wbamberg, estelle and bsmth October 1, 2024 11:07
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Oct 1, 2024
@mdn mdn deleted a comment from github-actions bot Oct 1, 2024
@mdn mdn deleted a comment from github-actions bot Oct 1, 2024
@estelle
Copy link
Member

estelle commented Oct 2, 2024

Instead of adding an accessibility section in all but the <math> case, we would be better served by a Technical Summary. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/area#technical_summary.

If we do include an accessibility section, it should explain how to make each element accessible.

The math example includes interesting information. The browser knows <mfrac> is "fraction start". This is not a defined ARIA role, but it is relevant to an accessibility explainer on the <mfrac> page. Within a <math>, the elements have seman tic meaning. The dash in an <mo> is known to be an operator, so read as "negative", while outside of an <mo> (not sure if within a <math> is required by the AOM to interpret it) a dash is usually not read I don't think.

@pepelsbey
Copy link
Member Author

Instead of adding an accessibility section in all but the <math> case, we would be better served by a Technical Summary.

@estelle Good point! I moved the lack of roles into the technical summary and kept the accessibility section only for <math> where there’s something to say.

estelle
estelle approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is great. 🎉

@pepelsbey pepelsbey merged commit a9a6b72 into mdn:main Oct 25, 2024
8 checks passed
@pepelsbey pepelsbey deleted the mathml-roles branch October 25, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@fred-wang fred-wang Awaiting requested review from fred-wang

@scottaohara scottaohara Awaiting requested review from scottaohara

Assignees
No one assigned
Labels
Content:MathML MathML docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepelsbey @fred-wang @estelle