Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(env): update required node engine to v18.18 #34443

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix(env): update required node engine to v18.18 #34443

merged 2 commits into from
Jun 27, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested review from mdn-bot and a team as code owners June 27, 2024 08:03
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/xs [PR only] 0-5 LoC changed labels Jun 27, 2024
bsmth
bsmth reviewed Jun 27, 2024
View reviewed changes
.nvmrc
@@ -1 +1 @@
v18.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be mirroring Yari here https://github.com/mdn/yari/blob/main/.nvmrc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping using v18.18 will force users to switch to v18.18. But v18 is required by GH workflows.

I guess we'll have to ask contributors to run fnm install $(fnm ls-remote | grep -iPo 'v18[.\d]*' | tail -n1) (change fnm to nvm for nvm) to switch to the latest v18 version which i not v18.18 but v18.20.2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But v18 is required by GH workflows.

OK, let's go for it. I guess we're not going to be tinkering with nvm for long given the incoming backend changes.

OnkarRuikar
OnkarRuikar commented Jun 27, 2024
View reviewed changes
.nvmrc Outdated Show resolved Hide resolved
bsmth
bsmth approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@bsmth bsmth merged commit 4f3cf53 into mdn:main Jun 27, 2024
16 of 17 checks passed
@OnkarRuikar OnkarRuikar deleted the nvm branch June 27, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

@mdn-bot mdn-bot Awaiting requested review from mdn-bot mdn-bot is a code owner

Assignees
No one assigned
Labels
size/xs [PR only] 0-5 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @bsmth