Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(htmlelement): clean 'inherit' concept in contentEditable #31935

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix(htmlelement): clean 'inherit' concept in contentEditable #31935

merged 2 commits into from
Jan 29, 2024

Conversation

dancer1325
Copy link
Contributor

Description

  • Clean the invalid inherit as value in contentEditable

Motivation

  • It's not valid anymore

Additional details

Related issues and pull requests

@dancer1325 dancer1325 requested a review from a team as a code owner January 26, 2024 10:10
@dancer1325 dancer1325 requested review from wbamberg and removed request for a team January 26, 2024 10:10
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jan 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-01-29 20:06:27)

@dancer1325
Copy link
Contributor Author

cc: @OnkarRuikar / @dabuside

estelle
estelle approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Also, congratulations on your first MDN content merged PR. Welcome to the team.

@estelle estelle merged commit 61f855f into mdn:main Jan 29, 2024
8 checks passed
@Josh-Cena Josh-Cena mentioned this pull request Jun 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancer1325 @estelle