FF122 Date parser parses first three chars of month #31931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
requested review from
Josh-Cena and
bsmth
and removed request for
a team
github-actions
bot
added
Content:JS
|
Preview URLs
External URLs (1)URL:
(comment last updated: 2024-02-09 00:05:19) |
10 tasks
bsmth
reviewed
Jan 26, 2024
files/en-us/web/javascript/reference/global_objects/date/parse/index.md
Outdated
Show resolved
Hide resolved
bsmth
reviewed
Jan 26, 2024
| @@ -94,6 +94,14 @@ Date.parse("2014-02-30"); | |||
| // NaN in Safari and Firefox; | |||
| // 1393718400000 in Chrome (Sun Mar 02 2014 00:00:00 GMT+0000) | |||
| Date.parse("02/30/2014"); // 1393718400000 in all implementations | |||
|
|
|||
There was a problem hiding this comment.
Out of scope of this PR, but I think this section is getting a little disorganized. Maybe in future we can separate this code block into categories or subsections.
bsmth
approved these changes
Jan 26, 2024
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
size/s
hamishwillee
commented
Feb 9, 2024
files/en-us/web/javascript/reference/global_objects/date/parse/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Thomas Smith <[email protected]>
|
Thanks for the review @bsmth - much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parity with Chrome/Safari the data parsers now only looks at the first three characters of the month when parsing non-standard date strings. Previously it would parse only valid truncated values of the month name - e.g. for december it might accept Dec, Dece, Decemb, December. Now it will accept DecFooo like the other browsers.
This adds a release note and an example in the
Date.parse()function.Related docs work can be tracked in #31930