-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bouncing logic respects ball radius #31922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
Web API docs
size/m
[PR only] 51-500 LoC changed
labels
Jan 25, 2024
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
Preview URLs (comment last updated: 2024-01-27 00:03:07) |
wbamberg
reviewed
Jan 25, 2024
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
…dex.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GniLudio
commented
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wraps long code and fixes a typo
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: wbamberg <[email protected]>
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/canvas_api/tutorial/advanced_animations/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
size/l
[PR only] 501-1000 LoC changed
and removed
size/m
[PR only] 51-500 LoC changed
labels
Jan 26, 2024
wbamberg
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thank you @GniLudio , nice update :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the bouncing logic so that it respects the radius of the ball.
So instead of the center of the ball, the edge of the ball triggers the bounce.
Motivation
Additional details
Related issues and pull requests