Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bouncing logic respects ball radius #31922

Merged
merged 13 commits into from
Jan 27, 2024
Merged

Bouncing logic respects ball radius #31922

merged 13 commits into from
Jan 27, 2024

Conversation

GniLudio
Copy link
Contributor

Description

Changed the bouncing logic so that it respects the radius of the ball.
So instead of the center of the ball, the edge of the ball triggers the bounce.

Motivation

Additional details

Related issues and pull requests

@GniLudio GniLudio requested a review from a team as a code owner January 25, 2024 23:04
@GniLudio GniLudio requested review from wbamberg and removed request for a team January 25, 2024 23:04
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Jan 25, 2024
Copy link
Contributor

github-actions bot commented Jan 25, 2024

Preview URLs

(comment last updated: 2024-01-27 00:03:07)

…dex.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor Author

@GniLudio GniLudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wraps long code and fixes a typo

GniLudio and others added 7 commits January 26, 2024 10:09
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: wbamberg <[email protected]>
GniLudio and others added 3 commits January 26, 2024 12:08
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Jan 26, 2024
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @GniLudio , nice update :)

@wbamberg wbamberg merged commit 02724e0 into mdn:main Jan 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants