-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add docs for *VideoFrameCallback() methods #31762
feat: Add docs for *VideoFrameCallback() methods #31762
Conversation
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Preview URLs
Flaws (7)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
External URLs (3)URL:
URL:
(comment last updated: 2024-01-25 18:12:13) |
This comment was marked as off-topic.
This comment was marked as off-topic.
files/en-us/web/api/htmlvideoelement/cancelvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/cancelvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-owner LGTM with the suggestions applied.
files/en-us/web/api/htmlvideoelement/cancelvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/cancelvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
…index.md Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
…/index.md Co-authored-by: Thomas Steiner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go, with one remark and one suggestion.
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
…/index.md Co-authored-by: Thomas Steiner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chrisdavidmills, I've done a readthrough and left a few suggestions.
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/cancelvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/cancelvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/cancelvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
Thank you so much for the thorough and helpful review, @dipikabh! I think I've fixed everything; let me know if you think it needs anything else. |
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fixes look good, @chrisdavidmills. Thanks for taking the time to leave your responses :)
There's just two minor things, but the pages are looking in good shape. Feel free to merge when ready. Thank you for adding the docs!
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/requestvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/htmlvideoelement/cancelvideoframecallback/index.md
Outdated
Show resolved
Hide resolved
…/index.md Co-authored-by: Dipika Bhattacharya <[email protected]>
…/index.md Co-authored-by: Dipika Bhattacharya <[email protected]>
Description
HTMLVideoElement.requestVideoFrameCallback()
andHTMLVideoElement.cancelVideoFrameCallback()
have been supported in Chrome since version 83, and Safari since 15.4, but we haven't yet published docs for them.This PR fixes that.
See https://web.dev/articles/requestvideoframecallback-rvfc for a useful test demo.
Motivation
Additional details
Related issues and pull requests