Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump markdownlint-cli2 v0.12.0, (markdownlint v0.33.0) #31682

Merged
merged 1 commit into from
Jan 12, 2024
Merged

chore(deps): Bump markdownlint-cli2 v0.12.0, (markdownlint v0.33.0) #31682

merged 1 commit into from
Jan 12, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 12, 2024 •
edited
Loading

The PR #31681 needs some manual intervention.

  • For duplicate section headings rule, changed allow_different_nesting -> siblings_only
  • Table in @supports flagged as having empty cells
  • Typo in config

MDLint Reference:

https://github.com/DavidAnson/markdownlint/blob/9c77f92616c063a5d42f165cae2edb9e3418ac53/schema/.markdownlint.jsonc#L113-L117

@bsmth bsmth requested review from mdn-bot and a team as code owners January 12, 2024 16:05
@bsmth bsmth requested review from chrisdavidmills and removed request for a team January 12, 2024 16:05
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs system [PR only] Infrastructure and configuration for the project labels Jan 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/@supports
Title: @supports
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

teoli2003
teoli2003 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 89eeeef into mdn:main Jan 12, 2024
14 of 15 checks passed
@bsmth bsmth deleted the markdownlint-cli2-config branch January 16, 2024 11:57
@bsmth
Copy link
Member Author

bsmth commented Jan 16, 2024

Thank you 👍🏻

dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@bsmth @dipikabh
chore(deps): Bump markdownlint-cli2 v0.12.0, (markdownlint v0.33.0) (m…
6cdf92f 
…dn#31682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@mdn-bot mdn-bot Awaiting requested review from mdn-bot mdn-bot is a code owner

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsmth @teoli2003