Update template element description and add shadowrootmode attribute #31490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Preview URLs External URLs (1)URL:
(comment last updated: 2024-01-25 10:30:31) |
pepelsbey
force-pushed
the
shadowrootmode
branch
from
e8b2cf9 to
e9c5473
Compare
pepelsbey
requested review from
chrisdavidmills
and removed request for
a team
pepelsbey
requested review from
dipikabh and
bsmth
and removed request for
chrisdavidmills
This was referenced Jan 17, 2024
estelle
reviewed
Jan 18, 2024
dipikabh
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Thanks for these updates, @pepelsbey!
I've done primarily an edit review and added some suggestions :)
Co-authored-by: Dipika Bhattacharya <[email protected]>
|
@dipikabh thank you for the great suggestions! I applied them all :) |
dipikabh
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks for the updates, @pepelsbey!
I have a few more suggestions.
Co-authored-by: Dipika Bhattacharya <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
estelle
reviewed
Jan 25, 2024
Co-authored-by: Estelle Weyl <[email protected]>
dipikabh
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Declarative shadow DOM reuses the
<template>element for generating shadow root in the presence of theshadowrootmodeattribute. This element is no longer for templating only, that needs to be reflected, too.Motivation
To support existing implementations in Chrome and Safari and prepare for the upcoming Firefox support.
Related issues and pull requests