Further fixes to autocapitalize content #30775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
requested review from
dipikabh
and removed request for
a team
chrisdavidmills
requested review from
teoli2003
and removed request for
dipikabh
teoli2003
approved these changes
Dec 4, 2023
estelle
pushed a commit
to estelle/content
that referenced
this pull request
Dec 5, 2023
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #30734, we made some changes to the
autocapitalizeattribute content, as what was there seemed inaccurate and somewhat unhelpful.Unfortunately, this was merged before I realised that
autocapitalizeis a true global attribute (as it is relevant to any element that hascontenteditableset on it), and it is relevant to desktop browsers as well as mobile browsers (it just isn't relevant to text entry via physical keyboards; it IS relevant to alternative input mechanisms such as virtual keyboards and voice input).Therefore, I am opening this PR to update the content again. I have added all the nice new content we wrote into the
autocapitalizeglobal attribute page, and removed it from the relevant form elements, linking to the global attribute page instead. This should be a lot easier to maintain in the future at least.Apologies for the wasted time, @ryo-manba and @teoli2003.
Motivation
Additional details
Related issues and pull requests