Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fix of File and FileList interface #30720

Merged
merged 10 commits into from
Dec 2, 2023
Merged

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 1, 2023

Description

add {{AvailableInWorkers}} macros to File and FileList related pages

remove incorrect usage of {{ReadOnlyInline}} macros of FileList.item() method in FileList interface summary

cleanup File interface summary to remove inherits propertys and methods

add {{optional_inline}} macros for type param and lastModified param of File() constructor, also adding content for possible endings param, also rename its first and second param to fileBits and fileName to better reflect its meaning

fix some incorrect usage of {{APIRef("File API")}} macros in File() constructor and File.lastModified property

reference to spec https://w3c.github.io/FileAPI/

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 1, 2023
@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 1, 2023 18:57
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 1, 2023 18:57
@skyclouds2001 skyclouds2001 requested review from Elchi3 and removed request for a team December 1, 2023 18:57
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 8fd2ee7 into mdn:main Dec 2, 2023
7 checks passed
@skyclouds2001 skyclouds2001 deleted the file branch December 3, 2023 07:33
estelle pushed a commit to estelle/content that referenced this pull request Dec 5, 2023
* fix apiref

* rename parameters

* addpossible endings parameter

* add  {{optional_inline}} tag

* remove description for inherit properties

* remove  {{ReadOnlyInline}} of method

* add {{AvailableInWorkers}}

* style pretty

* use macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants