Extend the getTargetRanges method documentation #30718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new table mirroring an existing table in the W3C spec that explains the expected return values for the getTargetRanges method. Notably, this table highlights that for editing hosts that are not contenteditable, the expected return value for this method is an empty array (which is not currently clear anywhere except the W3C docs).
|
Preview URLs |
sideshowbarker
approved these changes
Dec 2, 2023
|
@jGowgiel, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉 |
estelle
pushed a commit
to estelle/content
that referenced
this pull request
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new table mirroring an existing table in the W3C spec that explains the expected return values for the
getTargetRangesmethod. Notably, this table highlights that for editing hosts that are notcontenteditable, the expected return value for this method is an empty array (which is not currently clear anywhere except the W3C docs).Motivation
When experimenting with
beforeinputandgetTargetRanges, I was confused to find that the result seemed to always be an empty array (even when I thought I was configuring everything correctly). The existing docs didn't explain that, per the W3C spec, returning an empty array is the expected behavior in certain scenarios.Additional details
Matching W3C spec: https://w3c.github.io/input-events/#interface-InputEvent-Methods