-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relnote(120): Zulu timezone for non-ISO Date.parse
formats
#30235
Conversation
Preview URLs External URLs (1)URL:
(comment last updated: 2023-11-20 15:11:15) |
@zfox23 I assigned to you because I saw you did the previous work. @vinnydiehl FYI You may already have had this discussion with someone, but if you see a bug that has a docs implication, can you please add the keyword |
I've checked the patterns already in there and there are some of them which are out of date. I can certainly add information about some of the new formats which are being supported. Does it matter that some of these formats only work in pre-release versions of Firefox right now? Thanks for the heads up on the |
Thank you for your contribution, @vinnydiehl, and thank you for the tag, @hamishwillee :)
It would be super helpful if you could please fix content that is out-of-date and add some of the newly-supported formats. It'd be great for you to include a comment in the JS code snippet that included data about the way the dates are parsed across browsers. With respect to time and parsing time, keeping a BCD-like table of what happens in what browser given a specific date format is going to be a maintenance nightmare. In my opinion, the "This section contains implementation-specific behavior that can be inconsistent across implementations" note coupled with the comments in the example snippet are sufficient to keep folks on their toes about the utter confusion that is the human concept of "Time". I will keep my eyes out for updates to this PR. Thanks again. |
Co-authored-by: Zach Fox <[email protected]>
Hi Zach! Thanks for adding Bugzilla links on this and my other relnote. Since the updates in the JS reference will not necessarily be limited to the changes in either of these relnotes, and involve existing points which are outdated, I think it'd be best to do the work in a separate PR. I've opened #30363 to track this work. |
Entry
(under the parent bullet point for the previous
Date.parse
fixes):'Z'
is now accepted for non-ISO formats (e.g.Jan 1 1970 10:00Z
)Bugzilla
https://bugzilla.mozilla.org/show_bug.cgi?id=1852422