Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relnote(120): Zulu timezone for non-ISO Date.parse formats #30235

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

vinnydiehl
Copy link
Contributor

Entry

(under the parent bullet point for the previous Date.parse fixes):

  • Timezone 'Z' is now accepted for non-ISO formats (e.g. Jan 1 1970 10:00Z)

Bugzilla

https://bugzilla.mozilla.org/show_bug.cgi?id=1852422

@vinnydiehl vinnydiehl requested a review from a team as a code owner November 13, 2023 10:35
@vinnydiehl vinnydiehl requested review from pepelsbey and removed request for a team November 13, 2023 10:35
@github-actions github-actions bot added the Content:Firefox Content in the Mozilla/Firefox subtree label Nov 13, 2023
Copy link
Contributor

github-actions bot commented Nov 13, 2023

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/120
Title: Firefox 120 for developers

(comment last updated: 2023-11-20 15:11:15)

@hamishwillee hamishwillee requested a review from zfox23 November 13, 2023 22:37
@hamishwillee
Copy link
Collaborator

  1. This is cool, but we should also update https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse#non-standard_date_strings with information about this
  2. If there are browser compatibility differences then it would be great to add https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse#browser_compatibility
  3. Ditto for relnote(121): Date.parse fixes and additions #30234

@zfox23 I assigned to you because I saw you did the previous work.

@vinnydiehl FYI You may already have had this discussion with someone, but if you see a bug that has a docs implication, can you please add the keyword dev-doc-needed. This allows the MDN team to pick it up when we come to do the docs for a release - we ensure that the release note, browser compatibility and docs are done are up to date at that point. I did this for this issue #30234. When we are done we change that to dev-doc-complete so everyone knows the work is done. We normally also cross link the bug to the MDN tracking work - for me these look something like this: #29778

@vinnydiehl
Copy link
Contributor Author

vinnydiehl commented Nov 14, 2023

we should also update https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse#non-standard_date_strings with information about this

I've checked the patterns already in there and there are some of them which are out of date.

I can certainly add information about some of the new formats which are being supported. Does it matter that some of these formats only work in pre-release versions of Firefox right now?

Thanks for the heads up on the dev-doc-needed tags, I've gone through and tagged all of the bugs in these last 2 PRs.

@zfox23
Copy link
Contributor

zfox23 commented Nov 15, 2023

Thank you for your contribution, @vinnydiehl, and thank you for the tag, @hamishwillee :)

we should also update https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse#non-standard_date_strings with information about this

I've checked the patterns already in there and there are some of them which are out of date.

I can certainly add information about some of the new formats which are being supported. Does it matter that some of these formats only work in pre-release versions of Firefox right now?

It would be super helpful if you could please fix content that is out-of-date and add some of the newly-supported formats. It'd be great for you to include a comment in the JS code snippet that included data about the way the dates are parsed across browsers.

With respect to time and parsing time, keeping a BCD-like table of what happens in what browser given a specific date format is going to be a maintenance nightmare. In my opinion, the "This section contains implementation-specific behavior that can be inconsistent across implementations" note coupled with the comments in the example snippet are sufficient to keep folks on their toes about the utter confusion that is the human concept of "Time".

I will keep my eyes out for updates to this PR. Thanks again.

Co-authored-by: Zach Fox <[email protected]>
@vinnydiehl
Copy link
Contributor Author

vinnydiehl commented Nov 18, 2023

Hi Zach! Thanks for adding Bugzilla links on this and my other relnote.

Since the updates in the JS reference will not necessarily be limited to the changes in either of these relnotes, and involve existing points which are outdated, I think it'd be best to do the work in a separate PR. I've opened #30363 to track this work.

@zfox23 zfox23 merged commit 669c13f into mdn:main Nov 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants