Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary prefixes/notes from box-shadow subfeatures #25742

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 22, 2025

Summary

Subfeatures of box-shadow have some misleading prefix statements (which is misleading, because the prefix applies to the parent feature) and some unnecessarily notes (duplicated from the parent).

Test results and supporting details

Related issues

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:l [PR only] 101-1000 LoC changed labels Jan 22, 2025
@caugner caugner requested a review from Elchi3 January 23, 2025 16:13
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been going back on forth on whether sub features should have the prefixes and if they should use the version number when it was available with the prefix or the later one without the prefix.

I think we decided what you have done here: No prefixes for sub features and sub features use the earlier version number.

@Elchi3 Elchi3 merged commit 40847b3 into main Jan 24, 2025
11 checks passed
@Elchi3 Elchi3 deleted the box-shadow-cleanup branch January 24, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants