Firefox Android doesn't support ScreenOrientation.unlock() yet #25690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied data from lock().
github-actions
bot
added
data:api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replicates the support statements from
ScreenOrientation.lock().Note: It is somewhat surprising that the feature was supposedly already added in Firefox Android 43 and removed in Firefox Android 79, but this is harder to research and definitely less severe than saying Firefox Android supports
unlock().Test results and supporting details
Firefox doesn't support
ScreenOrientation.{lock,unlock}()yet, so Firefox Android cannot support it either, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1744125Related issues
Fixes #15919.