Allowlist web-feature tags #25614
Merged
Allowlist web-feature tags #25614
+37
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
caugner
approved these changes
Jan 9, 2025
|
Once this lands, we could probably sync the tags similarly to how we sync |
|
Yes, exactly, I asked @queengooborg to get that done as a next step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent BCD authors from creating new web-features tags (i.e., BCD uses web-features IDs as an allowlist for tags)
Test results and supporting details
Updated test files so that
'web-features:foo'fails and'web-features:javascript'passes.Related issues
@ddbeck, Kadir and I talked about the entire workflow yesterday and while want BCD authors to use and apply existing web-feature IDs to BCD features (useful for when BCD features are renamed, or when existing features get additions), we want to prevent that entirely new feature IDs are created in BCD. Instead they should be created in web-features.
For more details, see web-platform-dx/web-features#1672 (comment)