Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change <url> to url() and link to Web/CSS/url_function #25582

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change <url> to url() and link to Web/CSS/url_function #25582

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05d53aa
Change `<url>` to `url()` and link to Web/CSS/url_function
caugner Jan 6, 2025
a3a4679
Add `symbols()` description
caugner Jan 6, 2025
e0a852a
Merge branch 'main' into 25413-change-url-type-to-function
caugner Jan 8, 2025
cdd41c1
Update css/types/url.json
caugner Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/properties/content.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@
"url": {
"__compat": {
"description": "`url()`",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/url_value",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/url_function",
"spec_url": "https://drafts.csswg.org/css-values/#urls",
"tags": [
"web-features:content"
Expand Down
1 change: 1 addition & 0 deletions css/properties/list-style-type.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3282,6 +3282,7 @@
},
"symbols": {
"__compat": {
"description": "`symbols()`",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/symbols",
"spec_url": "https://drafts.csswg.org/css-counter-styles/#symbols-function",
"tags": [
Expand Down
4 changes: 2 additions & 2 deletions css/types/url.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"types": {
"url": {
"__compat": {
"description": "`&lt;url&gt;`",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/url_value",
"description": "`url()`",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, but this is about <url>, right?

From #25413, I see <url> = <url()> | <src()>. So, this file at some point will have entries like this:

  • css types.url (<url>)
  • css.types.url.url (url())
  • css.types.url.src (src())

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this feature was about the <url> type, then shouldn't it have partial_implementation? The way I see it this feature currently only shows the support for url(), not <url>. And url() is likely more useful than <url> from a reader's point of view.

Note that #25081 proposed to add a src subfeature, but the only browser bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1707923) did not suggest that this will be implemented anytime soon.

"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/url_function",
"spec_url": "https://drafts.csswg.org/css-values/#urls",
"tags": [
"web-features:font-face"
Expand Down
Loading