Unset bind group by passing null to setBindGroup() #24936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
3 tasks
beaufortfrancois
approved these changes
Nov 4, 2024
caugner
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Chromium changes LGTM, but Deno/Safari should probably be reset:
Related spec change: gpuweb/gpuweb#3938
This reverts commit b8a4f72.
caugner
requested changes
Nov 15, 2024
caugner
approved these changes
Nov 15, 2024
This was referenced Nov 15, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Chrome 117 onwards, you can pass
nullas the second argument when calling https://developer.mozilla.org/en-US/docs/Web/API/GPUComputePassEncoder/setBindGroup#bindgroup, https://developer.mozilla.org/en-US/docs/Web/API/GPURenderPassEncoder/setBindGroup#bindgroup, and https://developer.mozilla.org/en-US/docs/Web/API/GPURenderBundleEncoder/setBindGroup#bindgroup to unset a previously-set bind group in the specified slot.This PR adds data points for this behavior. I copied the compat data from GPURenderBundleEncoder.setVertexBuffer.unset_vertex_buffer, as it was implemented at the same time in Chrome and is very similar behavior, so there is a good chance that other browsers will have implemented it at the same time too. I've not explicitly tested it though.
See https://developer.chrome.com/blog/new-in-webgpu-117#unset_bind_group for evidence of this change.
Note that the above link does not mention GPUComputePassEncoder/setBindGroup, but I tested it in Chrome and it works there as well.
Test results and supporting details
Related issues
Project issue: mdn/content#36375