added native nightly support for all popover features #21676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api
This was referenced Dec 19, 2023
Elchi3
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
I ran npm run traverse -- -t web-features:popover to see all features that have to do with popover.
api.HTMLButtonElement.popoverTargetAction
api.HTMLButtonElement.popoverTargetElement
api.HTMLElement.beforetoggle_event
api.HTMLElement.hidePopover
api.HTMLElement.popover
api.HTMLElement.showPopover
api.HTMLElement.toggle_event
api.HTMLElement.togglePopover
api.HTMLInputElement.popoverTargetAction
api.HTMLInputElement.popoverTargetElement
api.ToggleEvent
api.ToggleEvent.ToggleEvent
api.ToggleEvent.newState
api.ToggleEvent.oldState
css.selectors.backdrop.popover
css.selectors.popover-open
html.global_attributes.popover
html.global_attributes.popovertarget
html.global_attributes.popovertargetaction
This PR updates all of them except:
api.ToggleEvent
api.ToggleEvent.ToggleEvent
api.ToggleEvent.newState
api.ToggleEvent.oldState
Those are already marked as shipped in Firefox 120.
So this looks good to me. Thanks for your PR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Working on documenting popover features in nightly by default
Test results and supporting details
Built a bunch of code.pens and tested in FF Nightly
Related issues