Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data for Invokers (invoketarget, invokeaction, InvokeEvent) #21542

Conversation

keithamus
Copy link
Contributor

Summary

This PR drafts up the documentation for "Invokers" (OpenUI explainer). This is a new experimental API for enabling buttons to control interactive elements.

Test results and supporting details

Related issues

mdn/content#30829

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Dec 8, 2023
@keithamus keithamus force-pushed the add-data-for-invokers-invoketarget-invokeaction-invokeevent branch 2 times, most recently from 3fce276 to 3b9acc1 Compare December 8, 2023 09:59
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary syntax error fix, will do a full review later!

api/HTMLElement.json Outdated Show resolved Hide resolved
@queengooborg
Copy link
Contributor

It looks like you've got a number of JSON syntax errors in this PR. Would you mind fixing those up, and then running npm run fix to fix auto-fixable schema/data issues? (Note: you can run npm test to find any errors in the data!)

@keithamus
Copy link
Contributor Author

keithamus commented Dec 11, 2023

Unfortunately npm t consumes all my machines ram before it can finish, and then it just hangs.

@queengooborg
Copy link
Contributor

Unfortunately npm t consumes all my machines ram before it can finish, and then it just hangs.

Sorry to hear that! There's a lot that the linter script does in the project.

If you'd like, I'd be happy to push a commit to fix any remaining issues!

@keithamus keithamus force-pushed the add-data-for-invokers-invoketarget-invokeaction-invokeevent branch from abce58b to c0d3a87 Compare December 11, 2023 11:56
@keithamus
Copy link
Contributor Author

@queengooborg looks like I managed to get all issues resolved 🙏

@keithamus keithamus marked this pull request as ready for review December 23, 2023 14:36
@queengooborg queengooborg dismissed their stale review January 7, 2024 15:34

Changes have been made

@queengooborg queengooborg merged commit 600614e into mdn:main Mar 4, 2024
6 checks passed
@keithamus keithamus deleted the add-data-for-invokers-invoketarget-invokeaction-invokeevent branch March 4, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants