Update background-clip.json #20743
Update background-clip.json #20743
Conversation
This adds link to the Safari entry, and also fixes HTML syntax errors.
github-actions
bot
added
the
data:css
This is so the check for the HTML attribute syntax doesn't fail.
This is so another fix needed to merge this doesn't fail.
Remove information about the Chrome bug, which doesn't exist in Safari. Co-authored-by: Florian Scholz <[email protected]>
|
Looks like this cannot be merged yet due to an error on a required check. The unit testing script thinks that the entries are not properly sorted, but they are. |
|
hm, yes, I would also think that the current 79+ version range is more important than the older Edge 15 support. The compare script is in https://github.com/mdn/browser-compat-data/blob/main/scripts/lib/compare-statements.ts. @queengooborg, do you think we should tweak the script? |
There was a problem hiding this comment.
Apologies for the long delay in responding, this had gotten buried in my emails.
Looking through the code, I see that we specify that statements with partial implementation to be third out of forth in the order of statements, and alt. names to be second. This order seems reasonable to me: if the prefixed version of a feature has full support but the unprefixed version only has partial support, the prefixed version is more important. Because of this, I don't think we should change the script.
However, there is a workaround to this: we add a version_removed to the statement stating version_added: 15. This would solve the issue and better clarify the history of the feature as well:
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
|
@queengooborg not sure I understand the failure here now. Could you take another look? Thank you! |
|
Since the partial implementation statement didn't have a I've gone ahead and pushed the fix to resolve this! |
* Update background-clip.json Fixes mdn#15172 * fix background-clip.json This adds link to the Safari entry, and also fixes HTML syntax errors. * HTML syntax fix This is so the check for the HTML attribute syntax doesn't fail. * apply npm run fix This is so another fix needed to merge this doesn't fail. * Update css/properties/background-clip.json Remove information about the Chrome bug, which doesn't exist in Safari. Co-authored-by: Florian Scholz <[email protected]> * Revert 7b58a03 I needed to make this commit for correct display of the information at MDN Web Docs. * Update css/properties/background-clip.json Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]> * Add version_removed to Edge 12 statement --------- Co-authored-by: Florian Scholz <[email protected]> Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
Summary
Added correct information for Edge's
background-clipcompatibility, and added the link to the bug tracker for this issue.Test results and supporting details
Bug tracker: https://crbug.com/1339290
Related issues
Fixes #15172.
Fixes #16135.