-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of missing devtools details #20403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: why are some features of edge not a mirror of Chrome?
Because I missed updating them from the copied content. I will fix that. |
This pull request has merge conflicts that must be resolved before it can be merged. |
Hey @Rob--W, looks like this has been waiting on your review for a while! |
While I'm not against adding explicit entries for API support statuses in the BCD, the BCD also link to MDN documentation that haven't been merged yet. I am reluctant to merge these MDN articles, because they document Chrome-only behavior. It's my intent to revisit these PRs eventually, but it's a low priority for me. |
Should we try to get a Chrome reviewer for this one? |
That's not necessary. I am familiar with this API in both Firefox and Chrome. The difficulty here is presenting the content in a way such that it is obvious which parts are cross-browser and which ones are Chrome-only. The current documentation lists the least common denominator, so anyone who relies on that can build an extension that works across browsers. If we add the Chrome-specific bits here as well, then I'm concerned that an extension dev would try out the documentation and then become disappointed when they discovered that the documented features don't actually work in Firefox. |
I think that so long as the browser compatibility data is up to date, then we should be fine on that front. Web extensions don't have a standard specification that we can refer to, so since browsers are free to implement what they want to, I wouldn't expect much cross-browser support anyways. |
Also addresses #16859 |
This pull request has merge conflicts that must be resolved before it can be merged. |
This PR has been sitting around in need of a review for a while, and is the second oldest PR open. We should get this reviewed and landed, or close it! |
I think that it is okay for BCD notes to be added, even without mdn documentation. @rebloor could you update the PR and tag dotproto for review? If there is anything that requires my attention, please pm me. |
@rebloor Since this PR updates support data for Chromium, Firefox, and Safari, and we seem to be differently certain about each of the browsers, how about we split this up and extract Chromium/Safari changes into two separate PRs? I think it'll be easier to land it that way. PS: Meanwhile eef1292 has added some Chromium data for the devtools API. |
@rebloor Please let me know if there is anything I can help with to advance this PR. |
@caugner Sorry for not responding earlier. This one has been held up as I originally tied it to MDN doc changes for the APIs but it became subject to an, as yet unresolved, discussion about how far we go in the documenting features that aren't available on Firefox. In looking back, however, I do notice that Rob was happy to add the BCD. I'm also not sure how much of a challenge we have in eliminating the Before your Monday, I'll have a look at:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into all the version_added: true
instances.
Thanks @caugner - more from me by Monday |
Co-authored-by: Claas Augner <[email protected]>
@caugner thanks for tracking down the version information. I've incorporated the changes. If you're happy with the update, so am I, please go ahead and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebloor I had another look at those remaining ranges, and some of them appeared to be wrong (probably my own fault):
Co-authored-by: Claas Augner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So panels.sources
was first documented in Chrome 38 (chromium/chromium@8e78a4d), and referencedSourcesPanel
, for which documentation was only added in Chrome 41 (chromium/chromium@35a3d25).
Also, createSidebarPane
on SourcesPanel
was first documented in Chrome 41 (chromium/chromium@35a3d25).
I will see if I can dig into blink history to find out more, but overall this suggests these were added in or before Chrome 38. In Chrome 18, createSidebarPane
was only added on the ElementsPanel
, and this is likely where prior confusion came from.
@rebloor Sorry for these extra rounds, but I think this is finally in a state we can comfortably merge it?! |
Thanks @caugner was all rather old detail details to track down. |
Summary
Add details, previously missing for devtools features not supported in Firefox
Related issues
Complete devtools.inspectedWindow content#28131 containing complementary updates to complete devtools.inspectedWindow documentation coverage
Fixes #16859